Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: carry duration since epoch in heartbeat #51

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

The duration since epoch will be used as a non-decreasing monotonic clock to calculate the lease time between Metasrv and Datanode.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@MichaelScofield MichaelScofield marked this pull request as draft June 19, 2023 02:05
@MichaelScofield MichaelScofield marked this pull request as ready for review June 19, 2023 07:54
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu merged commit 5d5eb65 into GreptimeTeam:main Jun 19, 2023
@MichaelScofield MichaelScofield deleted the feat/duration-since-epoch branch June 19, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants