Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ddl task service #53

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Removes Create in the Router
  2. Adds DDL task service

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

proto/greptime/v1/meta/ddl.proto Outdated Show resolved Hide resolved

service DdlTask {
// Submits a DDL task to meta.
rpc SubmitDdlTask(AddDdlTaskRequest) returns (AddDdlTaskResponse);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to ask for the execution status?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns directly in the response.

@WenyXu
Copy link
Member Author

WenyXu commented Jun 28, 2023

PTAL @MichaelScofield @fengjiachun

@WenyXu WenyXu merged commit f82201d into GreptimeTeam:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants