-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ddl task service #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
feat/add-ddl-task
branch
from
June 28, 2023 03:11
50a5492
to
a4e33b1
Compare
WenyXu
force-pushed
the
feat/add-ddl-task
branch
from
June 28, 2023 03:11
a4e33b1
to
ade9d3a
Compare
fengjiachun
reviewed
Jun 28, 2023
proto/greptime/v1/meta/ddl.proto
Outdated
|
||
service DdlTask { | ||
// Submits a DDL task to meta. | ||
rpc SubmitDdlTask(AddDdlTaskRequest) returns (AddDdlTaskResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to ask for the execution status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It returns directly in the response.
WenyXu
force-pushed
the
feat/add-ddl-task
branch
from
June 28, 2023 04:55
44c3bc0
to
eb81ec3
Compare
MichaelScofield
approved these changes
Jun 28, 2023
WenyXu
force-pushed
the
feat/add-ddl-task
branch
from
June 28, 2023 06:54
f052ce9
to
4cc607c
Compare
fengjiachun
approved these changes
Jun 28, 2023
WenyXu
force-pushed
the
feat/add-ddl-task
branch
from
June 28, 2023 07:20
4cc607c
to
b7eeec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Create
in the RouterChecklist
Refer to a related PR or issue link (optional)