Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: from valuedata for value #82

Merged
merged 1 commit into from
Aug 21, 2023
Merged

feat: from valuedata for value #82

merged 1 commit into from
Aug 21, 2023

Conversation

fengjiachun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

impl From<ValueData> for Value

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengjiachun fengjiachun mentioned this pull request Aug 19, 2023
Merged
2 tasks
evenyag
evenyag approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield merged commit 3489b47 into main Aug 21, 2023
6 checks passed
@MichaelScofield MichaelScofield deleted the feat/from-valuedata branch August 21, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengjiachun @MichaelScofield @evenyag