Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename RegionServer to Region #85

Merged
merged 2 commits into from
Aug 25, 2023
Merged

chore: rename RegionServer to Region #85

merged 2 commits into from
Aug 25, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Aug 25, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • rename RegionServer to Region, to avoid generating structs like RegionServerServer and RegionServerService
  • rename request to region_request_body, to make it more distinguishable

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@waynexia
chore: rename RegionServer to Region
c95aa06 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@waynexia
add stream api
4a28911 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
fengjiachun
fengjiachun approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evenyag
evenyag approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit 708866d into main Aug 25, 2023
7 checks passed
@evenyag evenyag deleted the rename-region-server branch August 25, 2023 09:01
@evenyag evenyag mentioned this pull request Aug 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waynexia @killme2008 @fengjiachun @evenyag