Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor changes to region server #88

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: minor changes to region server #88

merged 1 commit into from
Aug 28, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Remove streaming API as not planned
  • Use Rows in insert/delete request

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@waynexia
fix: minor changes to region server
b18309f 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
fengjiachun
fengjiachun approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 39b0ea8 into main Aug 28, 2023
6 checks passed
@waynexia waynexia deleted the fix-region-server branch August 28, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynexia @fengjiachun @evenyag