Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update primary key comment #89

Merged
merged 1 commit into from
Aug 28, 2023
Merged

docs: update primary key comment #89

merged 1 commit into from
Aug 28, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Aug 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Documents that primary_key holds ids of columns.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag
docs: update primary key comment
936a029 
Documents that primary_key holds ids of columns.
@evenyag evenyag marked this pull request as ready for review August 28, 2023 09:00
fengjiachun
fengjiachun approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag merged commit ec2d346 into main Aug 28, 2023
11 checks passed
@evenyag evenyag deleted the evenyag-patch-1 branch August 28, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evenyag @MichaelScofield @fengjiachun