Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a missing CMakeLists.txt file #98

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: add a missing CMakeLists.txt file #98

merged 1 commit into from
Sep 6, 2023

Conversation

niebayes
Copy link
Contributor

@niebayes niebayes commented Sep 4, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add a missing but required CMakeLists.txt file in the c++ directory.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

v0y4g3r
v0y4g3r approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 620337b into GreptimeTeam:main Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nateiru Nateiru Nateiru approved these changes

@v0y4g3r v0y4g3r v0y4g3r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niebayes @v0y4g3r @Nateiru