feat: region storage path #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
reviewed
Sep 15, 2023
waynexia
approved these changes
Sep 15, 2023
Co-authored-by: Weny Xu <wenymedia@gmail.com>
WenyXu
approved these changes
Sep 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2404 +/- ##
===========================================
+ Coverage 77.50% 77.56% +0.06%
===========================================
Files 715 715
Lines 113300 113391 +91
===========================================
+ Hits 87813 87952 +139
+ Misses 25487 25439 -48 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat: region storage path * Update src/common/meta/src/key/datanode_table.rs Co-authored-by: Weny Xu <wenymedia@gmail.com> * chore: by cr * feat: upgrade proto --------- Co-authored-by: Weny Xu <wenymedia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
In the past, we put the
catalogandschemainto theCreateRegionRequestand sent the request to the datanode to create regions, but in fact the datanode does not understand the meaning of the catalog and schema, it just uses this information to create the storage directory, we should directly pass in the "path"Upgrade the Proto synchronously : GreptimeTeam/greptime-proto#102
Checklist
Refer to a related PR or issue link (optional)