-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add some tables for information_schema
#3060
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
- Coverage 85.35% 84.94% -0.42%
==========================================
Files 800 800
Lines 129395 129572 +177
==========================================
- Hits 110441 110060 -381
- Misses 18954 19512 +558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy new year, a great work! Thank you.
I think we could ignore this table. cc @sunng87 @killme2008 |
Yes, of course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
Co-authored-by: Yingwen <realevenyag@gmail.com>
I commit the suggestion and it will be merged automatically. |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add some tables that is
not implemented
forinformation_schema
, includes:GLOBAL_STATUS, OPTIMIZER_TRACE, PARAMETERS, PROFILING, REFERENTIAL_CONSTRAINTS, ROUTINES, SCHEMA_PRIVILEGES, SESSION_STATUS, TABLE_PRIVILEGES, TRIGGERS
.As for
TABLESPACES
table, according to mysql doc:This table is unused. It is deprecated; expect it to be removed in a future MySQL release. Other INFORMATION_SCHEMA tables may provide related information
. Should I skip this table?Checklist
Refer to a related PR or issue link (optional)
#2931