Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add more integration test for kafka wal #3190

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

niebayes
Copy link
Contributor

@niebayes niebayes commented Jan 18, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title said.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M and removed docs-not-required This change does not impact docs. labels Jan 18, 2024
@niebayes niebayes added the docs-not-required This change does not impact docs. label Jan 18, 2024
@niebayes niebayes self-assigned this Jan 18, 2024
@niebayes niebayes force-pushed the test/add_wal_integration_test branch from beded12 to 9a816ba Compare January 18, 2024 07:01
@niebayes niebayes marked this pull request as draft January 18, 2024 13:08
@niebayes niebayes force-pushed the test/add_wal_integration_test branch from 2280be3 to 7c74b88 Compare January 21, 2024 12:36
@niebayes niebayes marked this pull request as ready for review January 22, 2024 04:09
@niebayes niebayes requested a review from WenyXu January 23, 2024 04:31
@killme2008
Copy link
Contributor

What's the status of this PR? @niebayes

@niebayes niebayes self-assigned this Mar 26, 2024
@niebayes niebayes force-pushed the test/add_wal_integration_test branch 2 times, most recently from 8c31f8a to 3186861 Compare March 27, 2024 09:58
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (92a8e86) to head (4a19d23).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3190      +/-   ##
==========================================
- Coverage   85.35%   85.01%   -0.34%     
==========================================
  Files         931      931              
  Lines      154611   154617       +6     
==========================================
- Hits       131961   131449     -512     
- Misses      22650    23168     +518     

@niebayes niebayes force-pushed the test/add_wal_integration_test branch from c6ebba7 to b8e58bd Compare March 27, 2024 13:41
@niebayes niebayes requested a review from WenyXu March 28, 2024 02:45
@niebayes niebayes force-pushed the test/add_wal_integration_test branch from b8e58bd to ac5290c Compare March 28, 2024 03:23
@niebayes niebayes force-pushed the test/add_wal_integration_test branch from ac5290c to 4a19d23 Compare March 28, 2024 03:37
@niebayes niebayes added this pull request to the merge queue Mar 28, 2024
Merged via the queue into GreptimeTeam:main with commit d5ba2fc Mar 28, 2024
18 checks passed
@niebayes niebayes deleted the test/add_wal_integration_test branch March 28, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants