Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect version info in #3586

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The build script in cmd won't rerun if the current git HEAD is changed, and will likely produce an incorrect result in --version.

image

But our release is not affected as the environment is clear for each release build.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 26, 2024
@waynexia waynexia enabled auto-merge March 26, 2024 08:40
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (7c1c6e8) to head (670f41a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   85.25%   84.88%   -0.38%     
==========================================
  Files         917      924       +7     
  Lines      152892   153487     +595     
==========================================
- Hits       130344   130283      -61     
- Misses      22548    23204     +656     

@waynexia waynexia added this pull request to the merge queue Mar 26, 2024
Merged via the queue into GreptimeTeam:main with commit 8f9676a Mar 26, 2024
19 checks passed
@waynexia waynexia deleted the trigger-version-info branch March 26, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants