-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(procedure): support to rollback #3625
Merged
fengjiachun
merged 14 commits into
GreptimeTeam:main
from
WenyXu:feat/procedure-rollback
Apr 8, 2024
Merged
feat(procedure): support to rollback #3625
fengjiachun
merged 14 commits into
GreptimeTeam:main
from
WenyXu:feat/procedure-rollback
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
feat/procedure-rollback
branch
from
April 1, 2024 08:50
548fa96
to
51a5103
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3625 +/- ##
==========================================
- Coverage 85.12% 84.85% -0.27%
==========================================
Files 946 946
Lines 157735 158035 +300
==========================================
- Hits 134277 134106 -171
- Misses 23458 23929 +471 |
WenyXu
force-pushed
the
feat/procedure-rollback
branch
2 times, most recently
from
April 2, 2024 09:48
fb8c8a6
to
d773510
Compare
WenyXu
force-pushed
the
feat/procedure-rollback
branch
2 times, most recently
from
April 3, 2024 06:52
42a2a23
to
cab8e3d
Compare
evenyag
reviewed
Apr 7, 2024
evenyag
reviewed
Apr 8, 2024
WenyXu
force-pushed
the
feat/procedure-rollback
branch
from
April 8, 2024 08:59
f18c726
to
5e949a1
Compare
evenyag
approved these changes
Apr 8, 2024
fengjiachun
reviewed
Apr 8, 2024
fengjiachun
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Support to rollback failed procedures
rollback
method to theProcedure
trait, the method requires an idempotent implementation.CommitRollback
,RollingBack
states toProcedureState
.Checklist