Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl table_constraints table for information_schema #3698

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Apr 12, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#2931

What's changed and what's your intention?

Main changes, adds table_constraints to information_schema. Refer to https://dev.mysql.com/doc/refman/8.0/en/information-schema-table-constraints-table.html

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 12, 2024
@killme2008 killme2008 mentioned this pull request Apr 12, 2024
37 tasks
@killme2008 killme2008 marked this pull request as ready for review April 13, 2024 06:57
@killme2008 killme2008 requested a review from a team as a code owner April 13, 2024 06:57
@killme2008 killme2008 force-pushed the feature/table-constraints branch from 298f90a to 7562424 Compare April 13, 2024 06:58
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Apr 13, 2024
@killme2008 killme2008 requested review from tisonkun and zhongzc April 13, 2024 07:00
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 23.19588% with 149 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (db329f6) to head (7562424).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3698      +/-   ##
==========================================
- Coverage   85.57%   85.16%   -0.41%     
==========================================
  Files         962      963       +1     
  Lines      160274   160464     +190     
==========================================
- Hits       137155   136661     -494     
- Misses      23119    23803     +684     

Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@waynexia waynexia added this pull request to the merge queue Apr 15, 2024
Merged via the queue into GreptimeTeam:main with commit 75d85f9 Apr 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants