-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create view #3807
feat: create view #3807
Conversation
54b509c
to
3b8b072
Compare
Lots of changes related to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3807 +/- ##
==========================================
- Coverage 85.79% 85.35% -0.45%
==========================================
Files 965 966 +1
Lines 165107 165879 +772
==========================================
- Hits 141654 141580 -74
- Misses 23453 24299 +846 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Jeremyhi <jiachun_feng@proton.me>
Co-authored-by: Jeremyhi <jiachun_feng@proton.me>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Impl
CREATE [OR REPLACE] [IF NOT EXISTS] VIEW name AS query
statement, main changes:CreateViewProcedure
and metadata, gRPC stuff. feat: adds view expressions greptime-proto#165The core design of
CreateViewProcedure
:View
) and encoded logical plan as__view_info/{view_id}
item in backend.or_replace
is true which means replacing the exists view, it will do the updating operation of metadata.Remaining tasks:
DROP VIEW name
statement.Todo:
Checklist