-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use information_schema returns Unknown database #4774
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Can you add some tese to check this case? |
I've add a simple sqlness statement. |
Your case does not cover the error path. There is already such a clause a5c6aa0#diff-d6e1d3d2ed1d9e57be3abbad7d3133a6e46f90102a88e8876bd15b5b9835b7abR75 |
you are right, to cover the error case in sqlness, we need #4729 since the error can only be triggered with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4774 +/- ##
==========================================
- Coverage 84.54% 84.26% -0.28%
==========================================
Files 1117 1117
Lines 202738 202737 -1
==========================================
- Hits 171408 170845 -563
- Misses 31330 31892 +562 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4773
What's changed and what's your intention?
is_reserved_schema_name
check should only be done when creating new database/schema.Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist