-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto detecting local IP to use as hostname #5314
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
We don't need to create a new configuration item for this. Just make hostname an optional field and use local-ip-address when it's not provided. But what if there are multiple network interfaces? |
That crate uses netlink to find out local ip address, so system route table determines which interface to use when multiple interface are present. |
3d31b31
to
c9ffa91
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5314 +/- ##
==========================================
- Coverage 84.14% 84.11% -0.04%
==========================================
Files 1200 1202 +2
Lines 225414 226112 +698
==========================================
+ Hits 189682 190187 +505
- Misses 35732 35925 +193 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b3e38bb
to
3fa5248
Compare
* feat: auto detecting hostname * chore: update config.md * chore: bring back hostname * chore: apply suggestions from CR * chore: use const * chore: apply suggesions from CR * fix: fix sqlness
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Automatically detect the local IP to enable deployment in container environments where pod IPs cannot be obtained.
After enabling this feature, the datanode will report the auto-detected IPs as peer addresses.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.