Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create table after rename table #894

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented Jan 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix bug: table cannot be created after renaming

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Fixes #892

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #894 (6d62686) into develop (ecb71f8) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #894      +/-   ##
===========================================
- Coverage    86.31%   86.20%   -0.12%     
===========================================
  Files          427      427              
  Lines        57294    57293       -1     
===========================================
- Hits         49456    49388      -68     
- Misses        7838     7905      +67     
Flag Coverage Δ
rust 86.20% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mito/src/engine.rs 98.91% <100.00%> (-0.01%) ⬇️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 49.76% <0.00%> (-15.79%) ⬇️
tests-integration/src/test_util.rs 87.55% <0.00%> (-11.99%) ⬇️
src/common/substrait/src/df_expr.rs 30.16% <0.00%> (-0.66%) ⬇️
src/servers/src/opentsdb/handler.rs 94.84% <0.00%> (+1.03%) ⬆️
src/meta-srv/src/service/heartbeat.rs 87.23% <0.00%> (+1.06%) ⬆️
src/servers/src/opentsdb.rs 98.41% <0.00%> (+1.58%) ⬆️
src/servers/src/error.rs 40.74% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I leave a comment about the test.

src/datanode/src/tests/instance_test.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 merged commit 5dfc24e into GreptimeTeam:develop Jan 19, 2023
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: create table after rename table

* chore: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot create table with a name which is occupied before
3 participants