Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the unified artifacts manager #157

Merged
merged 7 commits into from
Oct 8, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 8, 2023

What's changed

  1. Add the unified artifacts manager to manage charts and binaries(we will add plugins in the future);

  2. REMOVE the old implementation of the artifacts manager;

Related issue: #151, #150.

@zyy17 zyy17 requested review from shawnh2 and daviderli614 October 8, 2023 01:21
@codecov-commenter
Copy link

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (5ae1c8c) 31.74% compared to head (2511309) 34.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #157      +/-   ##
===========================================
+ Coverage    31.74%   34.54%   +2.79%     
===========================================
  Files           10       10              
  Lines         1345     1297      -48     
===========================================
+ Hits           427      448      +21     
+ Misses         819      760      -59     
+ Partials        99       89      -10     
Files Coverage Δ
pkg/helm/helm.go 62.50% <87.50%> (+10.64%) ⬆️
pkg/utils/file/file.go 26.51% <16.66%> (-0.47%) ⬇️
pkg/deployer/baremetal/deployer.go 31.41% <2.63%> (-1.70%) ⬇️
pkg/artifacts/manager.go 57.19% <57.19%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/utils/file/file.go Show resolved Hide resolved
pkg/deployer/baremetal/deployer.go Show resolved Hide resolved
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnh2 shawnh2 merged commit dda81be into GreptimeTeam:develop Oct 8, 2023
6 checks passed
@zyy17 zyy17 deleted the feat/unify-artifacts-manager branch October 8, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants