Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the unified metadata manager #158

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 8, 2023

What's changed

The pkg/metadata is a simple implementation of a metadata manager that manages the artifacts file path.

Moreover, the manager should also manage the runtime metadata of different deployments. We can improve it in the next development(cc @shawnh2).

Related issue: #150.

@zyy17 zyy17 requested a review from shawnh2 October 8, 2023 07:40
@codecov-commenter
Copy link

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (dda81be) 34.54% compared to head (8c00048) 35.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    34.54%   35.17%   +0.63%     
===========================================
  Files           10       11       +1     
  Lines         1297     1359      +62     
===========================================
+ Hits           448      478      +30     
- Misses         760      787      +27     
- Partials        89       94       +5     
Files Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/artifacts/manager.go 56.42% <20.00%> (-0.77%) ⬇️
pkg/metadata/manager.go 85.29% <85.29%> (ø)
pkg/helm/helm.go 58.47% <50.00%> (-4.03%) ⬇️
pkg/deployer/baremetal/deployer.go 30.42% <19.23%> (-0.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2 shawnh2 merged commit 0cb66b9 into GreptimeTeam:develop Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants