-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add runtime manager for bare-metal cluster #169
refactor: add runtime manager for bare-metal cluster #169
Conversation
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 Can we put the metadata management( |
sounds great, let me refactor it! |
the failed test in https://github.com/GreptimeTeam/gtctl/actions/runs/6573826229/job/17857729564 will also be fixed in this PR |
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: sh2 <shawnhxh@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
===========================================
+ Coverage 35.80% 37.67% +1.87%
===========================================
Files 12 14 +2
Lines 1430 1189 -241
===========================================
- Hits 512 448 -64
+ Misses 814 646 -168
+ Partials 104 95 -9
☔ View full report in Codecov by Sentry. |
Signed-off-by: sh2 <shawnhxh@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
all the changes that has been made in this PR, is for the conveniency of later code refactors and migrations.