Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: sample() missing 1 required positional argument: 'space_prng' #133

Closed
Alwinator opened this issue Jul 20, 2020 · 5 comments · Fixed by #139
Closed

TypeError: sample() missing 1 required positional argument: 'space_prng' #133

Alwinator opened this issue Jul 20, 2020 · 5 comments · Fixed by #139
Labels
bug Something isn't working

Comments

@Alwinator
Copy link

grid2op/Action/SerializableActionSpace.py Line 89

Line 89: res.sample()

Needs to be replaced with: res.sample(self.space_prng)

@Alwinator Alwinator added the bug Something isn't working label Jul 20, 2020
@Tezirg Tezirg reopened this Jul 20, 2020
@Alwinator
Copy link
Author

@Tezirg I just tested it with the new commit and it works. Why did you reopen the issue?

@Tezirg
Copy link
Contributor

Tezirg commented Jul 20, 2020

@Tezirg I just tested it with the new commit and it works. Why did you reopen the issue?

We close issues once they have been propagated to the main repo in a release. Right now the fix is still on branch, on the dev fork (awaiting review)

@Alwinator
Copy link
Author

Okay, sounds good.

@steliospnnl
Copy link

I changed replaced line 89 and am still having the issue... Any ideas what I might be doing wrong?

@BDonnot
Copy link
Collaborator

BDonnot commented Jul 29, 2020

@steliospnnl hello :-)
Can you provide with an example on the broken code please ? We will do a new grid2op version soon (we hope) that will fix all the bugs encountered as of today (and there are quite a lot) :-)
Thanks

@BDonnot BDonnot linked a pull request Aug 3, 2020 that will close this issue
BDonnot added a commit that referenced this issue Apr 26, 2021
Adressing issue 196 and 185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants