Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Wrong changed status on BaseActio.impact_on_objects() for curtailment #364

Closed
Melon-PieldeSapo opened this issue Jul 26, 2022 · 1 comment · Fixed by #383
Closed

Bug: Wrong changed status on BaseActio.impact_on_objects() for curtailment #364

Melon-PieldeSapo opened this issue Jul 26, 2022 · 1 comment · Fixed by #383

Comments

@Melon-PieldeSapo
Copy link

Melon-PieldeSapo commented Jul 26, 2022 •
edited
Loading

Environment

  • Grid2op version: 1.7.2
  • System: windows 10

Bug description

Bug found doing code inspection:
i think on:
https://github.com/rte-france/Grid2Op/blob/51854262d02d96c1ee1798a78a86661d1ff971a1/grid2op/Action/BaseAction.py#L2814
it should be:
curtailment["changed"] = True

How to reproduce

Command line

Code snippet

Current output

Expected output
@Melon-PieldeSapo Melon-PieldeSapo changed the title Wrong changed status Bug: Wrong changed status on BaseActio.impact_on_objects() for curtailment Jul 26, 2022
@BDonnot
Copy link
Collaborator

BDonnot commented Jul 26, 2022

Thanks for noticing.

We'll address it asap.

BDonnot added a commit to BDonnot/Grid2Op that referenced this issue Nov 30, 2022
@BDonnot
adressing Grid2op#364
69afb2c
BDonnot added a commit to BDonnot/Grid2Op that referenced this issue Nov 30, 2022
@BDonnot
adding test for Grid2op#364
98fe64a
@BDonnot BDonnot linked a pull request Dec 12, 2022 that will close this issue
Update for version 1.8.0 #383
Merged
@BDonnot BDonnot mentioned this issue Dec 12, 2022
Merged
@BDonnot BDonnot closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update for version 1.8.0 BDonnot/Grid2Op
2 participants
@Melon-PieldeSapo @BDonnot