Extend ITIR type inference to collect the types of all subexpressions #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
reviewed
Feb 22, 2023
egparedes
reviewed
Feb 22, 2023
Comment on lines
401
to
402
| collected_types Mapping from the (Python) id of a node to its type. | ||
| constraints Set of constraints, where a constraint is a pair of types that need to |
There was a problem hiding this comment.
Please use the correct Google style format for the docstrings (as required by sphix-napoleon: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html#example-google)
Suggested change
| collected_types Mapping from the (Python) id of a node to its type. | |
| constraints Set of constraints, where a constraint is a pair of types that need to | |
| collected_types: Mapping from the (Python) id of a node to its type. | |
| constraints: Set of constraints, where a constraint is a pair of types that need to |
There was a problem hiding this comment.
Fixed. This should be adopted in the https://github.com/GridTools/gt4py/blob/main/CODING_GUIDELINES.rst at some point.
There was a problem hiding this comment.
It was already there in functional (https://github.com/GridTools/gt4py/blob/functional/CODING_GUIDELINES.md#docstrings), but it got lost during the merge. I will update soon the documents in master with the versions from the other branch.
|
Blocked by #1182 |
tehrengruber
force-pushed
the
itir_typing_all_nodes
branch
from
a33f239 to
6ee1f51
Compare
egparedes
approved these changes
Feb 24, 2023
tehrengruber
changed the title
tehrengruber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type inference on ITIR was previously only returning the type of a single expression. This PR introduces extends the inference to collect the type of all subexpressions and introduces a new function
_infer_allreturning a mapping from the (Python) id of a node to its type. As we start using this function we will make it public.