Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gitpod pre-commit and remove obsolete files #1176

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Improve Gitpod pre-commit and remove obsolete files #1176

merged 3 commits into from
Feb 27, 2023

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Feb 21, 2023 •
edited
Loading

pre-commit doesn't work if the vscode git ui is used in gitpod, patch it to load the correct venv

@havogt havogt requested review from DropD and egparedes February 21, 2023 09:14
@egparedes
Copy link
Contributor

I propose to make this PR specific about gitpod and I will clean up the pull request template part in another PR (#1189 )

@havogt havogt removed the request for review from DropD February 27, 2023 13:35
egparedes
egparedes approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@havogt havogt merged commit 789d334 into main Feb 27, 2023
@havogt havogt deleted the remove_obsolete_files branch February 27, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @egparedes