Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix[next]: Cleaner SID bindings #1225

Merged
merged 5 commits into from
Mar 29, 2023
Merged

fix[next]: Cleaner SID bindings #1225

merged 5 commits into from
Mar 29, 2023

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Mar 28, 2023

No description provided.

@havogt havogt mentioned this pull request Mar 29, 2023
Merged
egparedes
egparedes requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, just a couple of comments about style.

src/gt4py/next/otf/binding/pybind.py Show resolved Hide resolved
tests/next_tests/otf_tests/test_pybind_integration_test.py Outdated Show resolved Hide resolved
@havogt havogt requested a review from egparedes March 29, 2023 09:50
egparedes
egparedes approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

src/gt4py/next/otf/binding/pybind.py Show resolved Hide resolved
@havogt havogt merged commit 6fceb2c into GridTools:main Mar 29, 2023
@havogt havogt deleted the cleaner_sid_creation branch March 29, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havogt @egparedes