refactor[next]: Replace pybind11 with nanobind #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
requested changes
Jul 27, 2023
|
|
||
|
|
||
| nanobind_sid_conv = """\ | ||
| #include <nanobind/nanobind.h> |
There was a problem hiding this comment.
I still would prefer to have this in gridtools, e.g. if we improve that adapter (e.g. by passing over compile time sizes != any) all potential users will profit... If you don't like to do the move now, I will probably do it eventually.
|
I added #1306 for properly updating dependencies. Might be cleaner to merge that first and keep this PR small. (Cleanest would be to merge my PR without nanobind to update the unrelated deps first.) |
DropD
requested changes
Aug 8, 2023
tests/next_tests/unit_tests/otf_tests/binding_tests/test_pybind.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/otf_tests/test_pybind_build.py
Show resolved
Hide resolved
DropD
approved these changes
Aug 9, 2023
havogt
approved these changes
Aug 17, 2023
havogt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.