feat[next]: Pass sizes to temporaries from gt4py program #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oraries' into pass-sizes-to-temporaries # Conflicts: # src/gt4py/next/program_processors/codegens/gtfn/gtfn_module.py # tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
|
@DropD Would you please review
|
tehrengruber
requested changes
Nov 20, 2023
tehrengruber
requested changes
Dec 5, 2023
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_execution.py
Outdated
Show resolved
Hide resolved
| @@ -19,9 +19,12 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
I'll revisit the changes here in a later review round.
tehrengruber
changed the title
…gt4py into pass-sizes-to-temporaries
DropD
reviewed
Dec 6, 2023
halungge
added a commit
to C2SM/icon4py
that referenced
this pull request
Jan 19, 2024
halungge
added a commit
to C2SM/icon4py
that referenced
this pull request
Jan 19, 2024
* update code generation backend to gt4py changes after [PR](GridTools/gt4py#1359) * fix mypy
OngChia
pushed a commit
to C2SM/icon4py
that referenced
this pull request
Jan 14, 2025
* update code generation backend to gt4py changes after [PR](GridTools/gt4py#1359) * fix mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.mdfile adding the names of all the new contributors.