fix[next]: Default to Release in CMake #1420
Conversation
| @@ -44,7 +44,7 @@ class CMakeFactory( | |||
| """Create a CMakeProject from a ``CompilableSource`` stage object with given CMake settings.""" | |||
|
|
|||
| cmake_generator_name: str = "Ninja" | |||
| cmake_build_type: BuildType = BuildType.DEBUG | |||
There was a problem hiding this comment.
@DropD please check if the default make sense in 3 different places and consider this example in the configuration project
There was a problem hiding this comment.
Well, sort of. I would argue that CMakeProject does not need to have a default value, since we never instanciate it directly. It makes sense though, that the factories can have separate default values.
Consider that using pure cmake leads to slightly simpler debugging, and in debugging the compilation times might not be as crucial.
There is, therefore an argument for leaving the default for CMakeFactory at DEBUG, while changing it to RELEASE for CompiledbFactory... However, in practice this might be more consfusing than helpful...
|
Fixed in #1438 |
No description provided.