-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[next][dace]: Use constant shape for neighbor tables in local dimension #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-paul-mueller
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks very good, however, there are some small changes and clarification needed.
The majority is that you should change expressions like for k, _ in dict().item()
to for k in dict().keys()
, which makes things clearer.
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/utility.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/utility.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/utility.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_sdfg.py
Outdated
Show resolved
Hide resolved
philip-paul-mueller
approved these changes
Jan 25, 2024
philip-paul-mueller
added a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Jan 31, 2024
In PR GridTools#1422 @edopao introduced a mechanism to skip the SDFG translation. This PR moves this cache from the `run_dace_iterator()` function into the `build_sdfg_from_itir()` function.
philip-paul-mueller
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main purpose of this PR is to avoid the definition of shape symbols for array dimensions known at compile time. The local size of neighbor connectivity tables falls into this category. For each element in the origin dimension, the number of elements in the target dimension is defined by the attribute
max_neighbors
in the offset provider.Some side changes included in the PR:
max_neighbors
and other attributes of NeighborTable offset providers.itir_embedded.NeighborTableOffsetProvider
with generic typecommon.NeighborTable
in type annotations.list_get
for the case where the index is aSymbolExpr
, simply use a memlet.has_skip_values == False
, do not generate thecan_deref
check.conn_names
toconnectivity_names
.