test[next]: Add unit test for embedded inverse_image and fix bugs
#1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
reviewed
Jan 30, 2024
tests/next_tests/unit_tests/embedded_tests/test_nd_array_field.py
Outdated
Show resolved
Hide resolved
| @@ -632,3 +632,59 @@ def test_setitem_wrong_domain(): | |||
|
|
|||
| with pytest.raises(ValueError, match=r"Incompatible 'Domain'.*"): | |||
| field[(1, slice(None))] = value_incompatible | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
maybe also add a testcase with a 2D connectivity?
There was a problem hiding this comment.
To be honest I don't really understand if it makes sense to restrict the connectivity in that case. I have to think about it.
There was a problem hiding this comment.
note to myself:
Start from this case and look at corner cases
E_START, E_STOP = 0, 1
V_START, V_STOP = 0, 1
e2v_conn = common._connectivity([0,1], domain=domain(named_range(E,1), named_range(E2V, 2)))
the inverse image is probably
domain(named_range(E,0), named_range(E2V, 1))
There was a problem hiding this comment.
I've added some cases to test 2d connectivities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for
ConnectivityField.inverse_image().