fix[next][dace]: Fixes to DaCe backend to support latest ITIR #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It noticed we execute some tests that use cupy in the cpu CSCS-CI. These tests are always executed when cupy is installed (which usually means we have a gpu, but not necessarily). This PR changes this such that they are marked with `requires_gpu` and as such can be disabled.
Variadic generic type:
```python
ShapeT = TypeVarTuple("ShapeT")
class Dims(Generic[Unpack[ShapeT]]):
shape: tuple[Unpack[ShapeT]]
DimsT = TypeVar("DimsT", bound=Dims, covariant=True)
```
such that field type is as follows:
```python
Field[Dims[D0, D1, ...], DType]
```
## New: - "next.ffront": - ".past_to_itir": workflow step PAST -> ITIR - ".transform_utils": some utility functions moved from "next.ffront.decorator" ## Changed: - "Backend": - is not a "ProgramProcessor" anymore - still passes "is_program_backend" test - new attribute ".transformer", a workflow which prepares for the ".executor" - currently starts at "stages.PastClosure" (PAST node + args, kwargs) but will evolve into starting from function definition + args, kwargs - "ModularExecutor": - is now a "ProgramExecutor" (passes "is_processor_kind" test) - "program_processor_interface": - "is_program_backend" test now checks for existence of an ".executor" attribute, which must pass the executor test - "ffront.decorator": - several utilities and methods refactored out into the new modules - tests: test utils / fixtures refactored to deal with backends which are not executors --------- Co-authored-by: nfarabullini <nicoletta.farabullini@c2sm.ethz.ch> Co-authored-by: Rico Häuselmann <ricoh@cscs.ch>
Requires full type annotations in next.ffront.
Introduces `concat_where` to be used for boundary conditions. `where` will intersect all 3 fields. Therefore `where(klevel == 0, boundary_layer, interior)` will not work if `boundary_layer` is only defined on `klevel == 0`. `concat_where` will concatenate the fields that are selected by the mask regions. The `mask` is currently required to be 1 dimensional.
edopao
changed the title
kotsaloscv
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in DaCe backend to support latest ITIR:
Minor code cleanup: skip debug information for memlets.