Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[next][dace]: Bugfix for neighbors reduction with lift expressions #1599

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Jul 31, 2024

Addresses the issue reported in spcl/dace#1625

GT4Py was generating a wrong SDFG for icon4py stencil calculate_enhanced_diffusion_coefficients_for_grid_point_cold_pools

@kotsaloscv
Copy link
Contributor

this fixes the semantically incorrect stencil calculate_enhanced_diffusion_coefficients_for_grid_point_cold_pools .
Thanks Edo!

@edopao edopao marked this pull request as ready for review August 2, 2024 07:25
@edopao edopao requested a review from kotsaloscv August 2, 2024 07:25
Copy link
Contributor

@kotsaloscv kotsaloscv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me + tested it in icon4py

@edopao edopao merged commit 5bf0488 into GridTools:main Aug 2, 2024
31 checks passed
@edopao edopao deleted the dace-itir-fix_lifts branch August 2, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants