Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next][dace]: refactoring #1685

Merged
merged 4 commits into from
Oct 10, 2024
Merged

feat[next][dace]: refactoring #1685

merged 4 commits into from
Oct 10, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Oct 10, 2024 •
edited
Loading

Implements some refactoring changes discussed during review of #1683.

@edopao edopao marked this pull request as ready for review October 10, 2024 07:06
philip-paul-mueller
philip-paul-mueller reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much like the new Dataflow input concept.
There are some changes, but it is generally good.

src/gt4py/next/program_processors/runners/dace_common/workflow.py
@@ -40,7 +40,8 @@ def __init__(self, program: dace.CompiledSDFG):
]

def __call__(self, *args: Any, **kwargs: Any) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __call__(self, *args: Any, **kwargs: Any) -> None:
def __call__(self, *args: Any, **kwargs: Any) -> bool:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be None, to comply with the protocol definition:

class CompiledProgram(Protocol):
    """Executable python representation of a program."""

    def __call__(self, *args: Any, **kwargs: Any) -> None: ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for some reason I read the assert as a return.

src/gt4py/next/program_processors/runners/dace_common/workflow.py
@@ -104,7 +105,7 @@ def decorated_program(
*args: Any,
offset_provider: common.OffsetProvider,
out: Any = None,
) -> Any:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above, must be bool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I have to assert also on the result of fast_call

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated

@abc.abstractmethod
def connect(self, me: dace.nodes.MapEntry) -> None:
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the coding guide says that you have to use ... here, but I am not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked it up, according to the first point of this section it needs to be ....

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Show resolved Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_builtin_translators.py Show resolved Hide resolved
philip-paul-mueller
philip-paul-mueller approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one pass that is not changed into ... I made a note there.
Otherwise, LGTM.

src/gt4py/next/program_processors/runners/dace_common/workflow.py
@@ -40,7 +40,8 @@ def __init__(self, program: dace.CompiledSDFG):
]

def __call__(self, *args: Any, **kwargs: Any) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for some reason I read the assert as a return.

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated

@abc.abstractmethod
def connect(self, me: dace.nodes.MapEntry) -> None:
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked it up, according to the first point of this section it needs to be ....

src/gt4py/next/program_processors/runners/dace_fieldview/gtir_dataflow.py Outdated Show resolved Hide resolved
@edopao edopao merged commit 92e83f3 into GridTools:main Oct 10, 2024
31 checks passed
@edopao edopao deleted the dace-gtir-refactoring branch October 10, 2024 12:44
@edopao edopao mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-paul-mueller philip-paul-mueller philip-paul-mueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edopao @philip-paul-mueller