feat[next][dace]: Fix lowering of nested let-statements #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
changed the title
…dace-gtir-fix_let_stmts
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_fieldview/gtir_sdfg.py
Outdated
Show resolved
Hide resolved
philip-paul-mueller
previously approved these changes
Oct 24, 2024
philip-paul-mueller
approved these changes
Oct 25, 2024
| # nested SDFG as transient array/scalar storage. The exception is given by | ||
| # input arguments that are just passed through and returned by the lambda, | ||
| # e.g. when the lambda is constructing a tuple: in this case, the result | ||
| # data is non-transient, because it corresponds to an input node. |
There was a problem hiding this comment.
I would add that this is corrected by make_temps().
Comment on lines
699
to
708
| 1st if-branch: | ||
| Transient nodes actually contain some result produced by the dataflow | ||
| itself, therefore these nodes are changed to non-transient and an output | ||
| edge will write the result from the nested SDFG to a new intermediate | ||
| data node in the parent context. | ||
|
|
||
| 2nd and 3rd if-branch: | ||
| Non-transient nodes are just input nodes that are immediately returned | ||
| by the lambda expression. Therefore, these nodes are already available | ||
| in the parent context and can be directly accessed there. |
There was a problem hiding this comment.
I would put this description as comments.
Because, a docstring is supposed to be viewed without the source code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one corner case of nested let-statements, discovered in
test_tuple_unpacking_star_multiduring GTIR integration. Test case added.Additionally, fixed handling of symbol already defined in SDFG for #1695.