Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax recompose dependency #823

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

macrozone
Copy link
Contributor

@macrozone macrozone commented Jul 24, 2018

to avoid ending up with duplicated versions of recompose.

the carret ^ usually only cares about the first version number, so ^1.0.0 won't match 2.0.0 but any of 1.x.x

BUT: this is not true, if it starts with 0. Then, ^0.21.0 will match any 0.21.x but not 0.22.0 or higher.

Griddle major version

Changes proposed in this pull request

changing the version of recompose dependency

Why these changes are made

to avoid duplicate in client code

Are there tests?

same as before

to avoid ending up with duplicated versions of recompose.

the carret `^` usually only cares about the first version number, so `^1.0.0` won't match `2.0.0` but any of `1.x.x`

BUT: this is not true, if it starts with 0. Then, `^0.21.0` will match any `0.21.x` but not `0.22.0` or higher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant