Upgrade 0.17 alpha v2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message It's up to the caller to not mix networks.
…ther than address Addresses are expensive to create, as we need to know a network they are created for.
…attern Instantiating these classes is cheap, as they're stateless. And we only do that once per `Wallet` instance.
…rather than addresses Addresses are expensive to create, as we need to know a network they are created for.
The helpers from `TimeUtils` are affected by the mock clock, which is not desired for debug output.
… of `get()` to `CoinSelector`
This is so that the special handling for regtest network can work in future.
…ubleSpendTxns()` Addresses are expensive to create, as we need to know a network they are created for.
Addresses are expensive to create, as we need to know a network they are created for.
Also remove redundant check for `getConfidenceType() == BUILDING` and improve the JavaDoc.
…leSpendTxns()` too
…tests These tests use `MainNetParams` and `SigNetParams`, but not `UnitTestParams`.
The max target aspect is tested by the `difficultyTransitions*()` tests already.
…n.PONG` Our minimum version is at 70000 already.
It doesn't make much sense in a getter. It should be checked when adding a block to the chain, like all the other checks.
…()` and `hasLimitedBlockChain()` Our API is now fluent enough that we don't need them any more.
gruve-p
force-pushed
the
upgrade-0.17-alpha-v2
branch
from
e549875
to
c11bb58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.