Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set container height to 100% #67

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Set container height to 100% #67

merged 1 commit into from
Apr 21, 2020

Conversation

jscheel
Copy link
Contributor

@jscheel jscheel commented Apr 20, 2020

No description provided.

@jscheel
Copy link
Contributor Author

jscheel commented Apr 20, 2020

Need to dynamically set the max height of widget iframe when loading (1)

@jscheel jscheel requested a review from assimovt April 20, 2020 22:51
assimovt
assimovt approved these changes Apr 21, 2020
View reviewed changes
Copy link

@assimovt assimovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@jscheel jscheel merged commit 2b4d0e4 into master Apr 21, 2020
@jscheel jscheel deleted the full-height-container branch April 21, 2020 19:42
@jscheel jscheel added patch Increment the patch version when merged release Create a release when this pr is merged minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assimovt assimovt assimovt approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged release Create a release when this pr is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jscheel @assimovt