Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add query for hatched eggs / rewrite method around EggPokemon #166

Merged
merged 2 commits into from
Jul 24, 2016
Merged

add query for hatched eggs / rewrite method around EggPokemon #166

merged 2 commits into from
Jul 24, 2016

Conversation

vmarchaud
Copy link
Contributor

No description provided.

@stirante
Copy link

Are you sure you get correct data which is returned by queryHatchedEggs? I suspect the proto file may be a bit wrong since when I tried same code and then i returned in loop all getPokemonId(int) it returned pretty random numbers. Other than that hatching egg is correct since I tried it.

if (!egg.getIsEgg()) {
return null;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to match the style of the project you should remove this space

@jabbink jabbink mentioned this pull request Jul 24, 2016
@jabbink
Copy link
Collaborator

jabbink commented Jul 24, 2016

@jabbink jabbink mentioned this pull request Jul 24, 2016
2 tasks
@stirante
Copy link

Also sometimes using this i get "While parsing a protocol message, the input ended unexpectedly in the middle of a field. This could mean either that the input has been truncated or that an embedded message misreported its own length."

The proto file is definetly wrong.

@Grover-c13
Copy link
Owner

The issue might be from the proto using uint64 instead of fixed64, pokemon ids always seem to be fixed 64 and having them as uint seems to cause issues.

@vmarchaud
Copy link
Contributor Author

While parsing a protocol message, the input ended unexpectedly in the middle of a field. This could mean either that the input has been truncated or that an embedded message misreported its own length."
These packets are running error free with my bot.
Will look on for proto file.

@jabbink jabbink merged commit 1be9f75 into Grover-c13:Development Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants