Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Imp page #125

Merged
merged 10 commits into from
Oct 19, 2024
Merged

Added Imp page #125

merged 10 commits into from
Oct 19, 2024

Conversation

TanviGandhotra
Copy link
Contributor

Fixes #118
I have added new page:
image
have added button in main page
image
Hope u like it.

Type of change

  • New feature (non-breaking change)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra Nice work! try to run npm run format to see why check is failing. then we are ready to merge.

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra As i have checked the content is cutting when is page is at 100% width of the website
Fix this:
{A30F1973-BE65-402A-AB58-D4057CEB9BCD}

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 srry give me just 5 min i will fix this

@TanviGandhotra
Copy link
Contributor Author

TanviGandhotra commented Oct 13, 2024

image
now see @Anshgrover23

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra Not solved yet!
Kindly tell which browser are you using check before you commit.
{2B397A11-DFB4-447A-8614-BEA003F5EB4B}

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 i used chrome.dont know why this happening.its fine on my side

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra Do one thing make the content shorter so that it can fit in screen. If possible?

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 okay will do .Plzz stay online for 5 min so i get updates from u

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra Yes sure.

@TanviGandhotra
Copy link
Contributor Author

image
see @Anshgrover23 now.Let me know if its fine now

@Anshgrover23
Copy link
Collaborator

Anshgrover23 commented Oct 13, 2024

I think your browser width is currently set default at 80% or maybe 90% because in 100% width of the window it is going out of the screen do some research and find out. why it is happening.
{81790C9C-D2D4-47C5-A0C7-A1DF3E858C18}
in 100% window width
{5737F27B-9FE3-41B9-AF71-9EBA7EA70E73}

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra Beside this, you have done a great job. i am willingly to merge this but can not able to due to this bug.

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 np .I do something.Will definately make this merge.

@TanviGandhotra
Copy link
Contributor Author

will now see this after an hour .and approach you soon

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra sure.

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra resolve the conflicts. also, what 's the update on this ??

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 see
1.on 110% zoom
image
2. on 100%
image

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 plz check this.Hope it works fine now

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra where is that why we need this button without that how can this work.
{76B01E7D-DD0A-4083-AEE8-80A6070BD096}

@Anshgrover23
Copy link
Collaborator

@TanviGandhotra i think this is due to try to update your forked repository with main or sync with it.

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 done

@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 wait let me see bcs maine to dlt kra nhi

@TanviGandhotra
Copy link
Contributor Author

image

@Anshgrover23
Copy link
Collaborator

Anshgrover23 commented Oct 19, 2024

@TanviGandhotra good work!
i think this part is cutting from the screen by the way, I am merging your PR.
but can u please make a new issue regarding this problem as its extension? and do not forget to star the repository.

{6B54BA42-658B-435A-BEBA-92B7F4D665DF}

@Anshgrover23 Anshgrover23 merged commit 432983d into Groverio:main Oct 19, 2024
2 checks passed
@TanviGandhotra
Copy link
Contributor Author

@Anshgrover23 oh thnku so much.U still merged it,You value my hard work,I am really very happy.I will raise new issue regarding this for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] : Imp of to-do-list
2 participants