Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial Ruby32 #3418

Merged
merged 30 commits into from
Jul 13, 2024
Merged

Trial Ruby32 #3418

merged 30 commits into from
Jul 13, 2024

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Aug 11, 2023

Devcontainer at least starts.

Images (Fixed)

-Images and other things in the asset pipeline just don't work.-

Cause:
https://github.com/railsware/js-routes/pull/310/files

When removed:

image

DEPRECATION WARNING: Using a :default format for Date#to_s is deprecated

DEPRECATION WARNING: Using a :default format for Date#to_s is deprecated. Please use Date#to_fs instead. (called from render at /home/runner/work/growstuff/growstuff/vendor/bundle/ruby/3.2.0/bundler/gems/comfortable-mexican-sofa-ccf9415ae220/lib/comfortable_mexican_sofa/render_methods.rb:59)

DEPRECATION WARNING: Using a :default format for Date#to_s is deprecated. Please use Date#to_fs instead. (called from planting_reminder at /home/runner/work/growstuff/growstuff/app/mailers/notifier_mailer.rb:57)

Gemfile.lock Show resolved Hide resolved
@cesy cesy mentioned this pull request Jul 11, 2024
.devcontainer/.env Outdated Show resolved Hide resolved
@CloCkWeRX
Copy link
Collaborator Author

Devcontainer is limited to ruby 3.2.2 :/

@CloCkWeRX
Copy link
Collaborator Author

CloCkWeRX commented Jul 13, 2024

Once again, Heroku is "helping" by ignoring we use bundler 2.4.10

-----> Building on the Heroku-22 stack
-----> Using buildpack: heroku/ruby
-----> Ruby app detected
-----> Installing bundler 1.17.3
-----> Removing BUNDLED WITH version in the Gemfile.lock
-----> Compiling Ruby/Rails
###### WARNING:
       Your app was upgraded to bundler 1.17.3.
       Previously you had a successful deploy with bundler 2.3.25.
       
       If you see problems related to the bundler version please refer to:
       https://devcenter.heroku.com/articles/bundler-version#known-upgrade-issues
       

 !
 !     There was an error parsing your Gemfile, we cannot continue
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:29: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:29: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:35: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:35: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:44: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     The git source `git://github.com/jquery-ui-rails/jquery-ui-rails.git` uses the `git` protocol, which transmits data without encryption. Disable this warning with `bundle config git.allow_insecure true`, or switch to the `https` protocol to keep your data secure.
 !     /tmp/d20240713-111-6a16zt/bundler-1.17.3/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:118: warning: Pathname#untaint is deprecated and will be removed in Ruby 3.2.
 !     You must use Bundler 2 or greater with this lockfile.
 !
 !     Push rejected, failed to compile Ruby app.
 !     Push failed

@CloCkWeRX
Copy link
Collaborator Author

@CloCkWeRX
Copy link
Collaborator Author

I should ban codeclimate, as it keeps telling us to break the heroku deploy.
Heroku is so fragile in that it parses bundled with expecting exactly three spaces.

@CloCkWeRX CloCkWeRX merged commit 000f497 into dev Jul 13, 2024
5 checks passed
@CloCkWeRX CloCkWeRX deleted the ruby32 branch July 13, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants