Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1 #3590

Merged
merged 23 commits into from
Jan 26, 2024
Merged

Rails 7.1 #3590

merged 23 commits into from
Jan 26, 2024

Conversation

CloCkWeRX
Copy link
Collaborator

No description provided.

@CloCkWeRX
Copy link
Collaborator Author

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. color("my text", :red, bold: true)). (called from tap at internal:kernel:90)

@CloCkWeRX
Copy link
Collaborator Author

Failed examples:

rspec ./spec/features/seeds/adding_seeds_spec.rb:27 # Seeds signed in displays required and optional fields properly is expected to have visible css ".form-group.required" with text "Heirloom?"
rspec ./spec/features/seeds/adding_seeds_spec.rb:26 # Seeds signed in displays required and optional fields properly is expected to have visible css ".form-group.required" with text "GMO?"
rspec ./spec/features/seeds/adding_seeds_spec.rb:29 # Seeds signed in displays required and optional fields properly is expected to have visible css ".form-group.required" with text "Will trade"
rspec ./spec/features/seeds/adding_seeds_spec.rb:25 # Seeds signed in displays required and optional fields properly is expected to have visible css ".form-group.required" with text "Organic?"
rspec ./spec/features/members/deletion_spec.rb:147 # member deletion with activity and followers deletes and can no longer sign in

@CloCkWeRX
Copy link
Collaborator Author

CloCkWeRX commented Jan 22, 2024

For:

      =  t('.trade_help', site_name: ENV['GROWSTUFF_SITE_NAME'])
      = f.select(:tradable_to, Seed::TRADABLE_TO_VALUES, {label: 'Will trade', wrapper: { class: 'required' }})

The output is

<label for="seed_tradable_to">Will trade</label><select class="form-control" name="seed[tradable_to]" id="seed_tradable_to"><option selected="selected" value="nowhere">nowhere</option>
<option value="locally">locally</option>
<option value="nationally">nationally</option>
<option value="internationally">internationally</option></select>

vs

<div class="form-group required"><label for="seed_tradable_to">Will trade</label><select class="form-control" name="seed[tradable_to]" id="seed_tradable_to"><option selected="selected" value="nowhere">nowhere</option>
<option value="locally">locally</option>
<option value="nationally">nationally</option>
<option value="internationally">internationally</option></select></div>
<span class="help_inline">
Don't forget to
<a href="/members/edit">set your location</a>.
</span>
</div>

@CloCkWeRX CloCkWeRX marked this pull request as ready for review January 26, 2024 14:08
@CloCkWeRX CloCkWeRX merged commit f338274 into dev Jan 26, 2024
6 checks passed
@CloCkWeRX CloCkWeRX deleted the rails71 branch January 26, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant