Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix vertical scrollbar dragging in rtl mode #666

Merged
merged 1 commit into from
Apr 15, 2023
Merged

fix(core): Fix vertical scrollbar dragging in rtl mode #666

merged 1 commit into from
Apr 15, 2023

Conversation

GSilidis
Copy link
Contributor

Should fix #659 issue.

Issue:

When dragging vertical scrollbar handle, it moves in reverse position when wrapper is in RTL mode. It looks like handle movement is reversed in RTL mode both, for horizontal (which is how it should be) and for vertical scrollbar (which is undesired behavior, as RTL layout doesn't change vertical page layout). You can also see the example in comments for issue, mentioned above.

What is done to fix it:

Add additional checks for dragging position: scroll handle movement is inverted when layout is RTL (older check) and only when moving X axis (new check)

@Grsmto
Copy link
Owner

Grsmto commented Apr 13, 2023

Thanks for this! I'll take a look ASAP.

@Grsmto Grsmto merged commit cd1cfbc into Grsmto:master Apr 15, 2023
@Grsmto
Copy link
Owner

Grsmto commented Apr 15, 2023

Released in simplebar@6.2.5 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drag scroll button
2 participants