swap terms correctly when moving tabs, fixes #473 and #512

Guake · Jul 24, 2015 · 69b63eb · 69b63eb
1 parent 16b2526
commit 69b63eb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/guake/guake_notebook.py b/src/guake/guake_notebook.py
@@ -31,8 +31,7 @@ def reorder_child(self, child, position):
         """ We should also reorder elements in term_list
         """
         old_pos = self.get_children().index(child)
-        terms = self.term_list
-        terms[old_pos], terms[position] = terms[position], terms[old_pos]
+        self.term_list.insert(position, self.term_list.pop(old_pos))
         super(GuakeNotebook, self).reorder_child(child, position)
 
     def has_term(self):