Font of active tab in tab bar is always white

[pszalanski]

The theme selection works fine for me, thanks for that.

However, no matter what theme I have selected, the active tab has a white font color, which makes it illegible on most of my themes, especially my system theme, which is Ambiance on Ubuntu.

See here:

[gsemet]

which version of guake are you under? Have you tried with latest version from HEAD?

[pszalanski]

It was checked out yesterday.

[abcarroll]

Having the same thing here. Had to downgrade to the version supplied by my distro's pkg manager, 3.2.2 edit: 3.0.5, and it stopped.

[pszalanski]

I guess this was caused by the following commit: 21cf658

[abcarroll]

Verified this. You can temporarily fix this by changing the css_data = assignment, around line 421 of guake/guake_app.py, as below:

        css_data = dedent(
            """
            .tab {{
              color: #aaaaaa;
            }}
            
            .tab:checked {{
              color: #000000;
              background-color: {};
            }}
            """.format(selected_bg_color)
        ).encode()

(of course, this would be just as "wrong" if you select a dark gtk theme)

If I understood the intent of 21cf658 a little better, I would attempt a real patch, but I just don't understand what the commit was trying to accomplish.

[gsemet]

I can reproduce it on latest. I'll see if I can fix it asap