-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guake moving to another monitor on mouse click #1720
Comments
I can confirm this behaviour. $ guake --supportGuake Version: 3.7.0 Vte Version: 0.52.2 Vte Runtime Version: 0.52.2 GTK+ Version: 3.22.30 GDK Backend: GdkX11.X11Display Desktop Session: cinnamon Display: :0 RGBA visual: True Composited: True
|
Same here. $ guake --supportGuake Version: 3.7.0Vte Version: 0.52.2 Vte Runtime Version: 0.52.2 GTK+ Version: 3.22.30 GDK Backend: GdkX11.X11Display Desktop Session: ubuntu Display: :0 RGBA visual: True Composited: True
|
Same here. Also, I can no longer maximize the window using Super+↑; it immediately un-maximizes. $ guake --supportGuake Version: 3.7.0 Vte Version: 0.52.2 Vte Runtime Version: 0.52.2 GTK+ Version: 3.22.30 GDK Backend: GdkX11.X11Display Desktop Session: ubuntu Display: :0 RGBA visual: True Composited: True
|
Same Here $ guake --supportGuake Version: 3.7.0 Vte Version: 0.52.2 Vte Runtime Version: 0.52.2 GTK+ Version: 3.22.30 GDK Backend: GdkX11.X11Display Desktop Session: ubuntu Display: :0 RGBA visual: True Composited: True
|
Presumably you don't have |
Same here with checked ✔️ When I disabled it, I do not have the bug anymore, but then I loose the mouse display feature. I would expect as before. Open the term where ever the mouse is, but do not change focus on mouse click. $ guake --supportGuake Version: 3.7.0 Vte Version: 0.52.2 Vte Runtime Version: 0.52.2 GTK+ Version: 3.22.30 GDK Backend: GdkX11.X11Display Desktop Session: ubuntu Display: :1 RGBA visual: True Composited: True
|
Pretty sure it was never meant to work this way. The terminal appears on your mouse display as per the option, it doesn't seem like a bug to me? |
Yes, disabling the |
@J-Schaefer Can you close the issue if you have a confirmed solution? |
before If I click on another screen, as my terminal was already open it was not moving the it to mouse place. This is the scenario that we expect What happens since the upgrade
|
Well, the solution is to disable one of the options. But I don't believe that the jumping of the window after it has been opened is a feature of Guake. So it's no real solution unfortunately. |
Thanks for the clarification! It's really comprehensible. I do appreciate that. |
In my local install I removed the code from the commit 5205ce2 which restored the expected functionality for the terminal positioning on mouse click. (I'm not familiar with the issue that commit was fixing though, so I may see some side effects from this.) |
I've reverted that commit manually and it worked as expected, thanks |
I believe I have the same issue. I have 3 monitors, and when I used to drop Guake on the left monitor to work on the center it used to stay there, but now it pops up on the monitor where I click the mouse. Once Guake lost its focus it will stay, but accidentally selecting it while tabbing will make Guake appear on the monitor with the mouse again. |
It seems the functions set_final_window_rect from RectCalculator is used at each window_event due to the commit 5205ce2 with the call of the function unfullscreen, causing the change of the monitor where Guake is shown. |
…ow manager Expect handling from accel-key fullscreen toggle, also handle from window state changed. Because if you bind same accel-key for fullscreen in window manager, you will not trigger it from Guake toggle fullscreen, instead from wm. This should fix wierd window size & position when first using Guake fullscreen toggle, then toggle fullscreen by wm hotkey.
I will confirm this is a recent change in behavior. I have 3 monitors. I open Guake on one, say the right one. If I click out of Guake onto anything on the right monitor, then click something in the middle or left monitor, it stays in place on the right monitor. If I do not click out of Guake, it moves monitors when I click on the middle or right monitor. Since this was never needed before, more often than not I forget to click out of Guake ( an uneeded extra click ) and end up just getting rid of Guake and opening Tilix since it doesn't move around on me. This is a recent change in behavior. Previously it stayed where it was. As for the check box in Preferences > Main Windows > Appear on mouse display, this is not really a good solution. If I uncheck it I can set which monitor to open on and that partially works as it will stay there. However, that presumes I always want it to open on one monitor, which is not the case. For me, I will use all three monitors at times depending on what I have open and where these open windows are placed. Otherwise I'd have to move everything I'm working on on one monitor to another one then open Guake so I can continue to do what I'm doing in my other windows. That or sacrifice one monitor specifically for Guake and not have anything else open on it, thus making it almost a wasted monitor as there's only specific times I use I use the terminal for more than 10 seconds. I suppose if I had a terminal open 100% of the time that would be acceptable. In the end I would like to see a return of the previous functionality where once I open it on a monitor, it stays there unless I tell it to move. Not move on its own accord. Thanks for the work on Guake! I do appreciate the program and like to use it, when it's not jumping around all over the place :p |
This is still an issue that is very annoying with multi-monitor setups. |
I can confirm this as well. Looking at the date of the commit & release that appears to be about the time I started having the issue as well. I started using guake a few years ago mainly due to being stuck on a tiny laptop screen at the time for the benefit of hiding and tabs (and maybe a little Quake nostalgia...) and it just grew on me. Since I never use the fullscreen toggle I'll probably do the same as @AbdElraoufSabri and manually revert it and build a temporary substitute for the current package I am using from the Arch community repo. Thank you to the author and all the maintainers for all your hard work! ` $ guake --supportGuake Version: 3.7.0 Vte Version: 0.60.0 Vte Runtime Version: 0.60.0 GTK+ Version: 3.24.14 GDK Backend: GdkX11.X11Display Desktop Session: xfce Display: :0.0 RGBA visual: True Composited: False
|
Downgrade to 3.6.3 helped me |
Downgrade or install different drop down terminal seems to be only option. Really sucks when you have mouse set to activate on hover. Just keeps popping a terminal on ever screen move. I love guake but need another option to only open on mouse position when activated not on click or on focus. |
I applied PR #1774 and that seems to have fixed the problem for me. |
I can confirm that this looks to be working for me as well. Finally! Good stuff For me, on Manjaro it was located in /usr/lib/python3.8/site-packages/guake/utils.py |
thanks @stiltr, it worked perfectly! I can confirm on pop os! |
https://ubuntu.pkgs.org/20.04/ubuntu-universe-i386/guake_3.6.3-2_all.deb.html works, ty. |
Can confirm that 9bfd2bc works |
It works out here too! |
3.6.3 stopped working after recent update.... So I guess I'm off to find a replacement.... |
Hi! This is still happening to me in version 3.7.0 in a virtual machine |
@JanezStupar & @Iakobs, did you try #1720 (comment)? |
The issue still persists, can somebody permanently apply the PR on the release version to fix an issue that was happening for years now? Why there is a reluctance from developers to fix the clear bug? FYI the fix from the PR is no longer working nor relevant as the code changed |
Missed cleaning up this issue because it wasn't linked in #1775, which was merged and released as part of Guake 3.8. #1774 was not merged because it was broken, and the submitter closed it to create another fix which was merged. Judging by the dredge, I assume that 1775 didn't fix it either? What version of Guake are you running? |
The latest shipped with Ubuntu 21.10
I also tested the latest version for Debian and same behavior. just getting some errors on certain commands which may be the case of non approved distro
|
3.8.x should have the patch. Did you confirm that you stopped the running instance of 3.7 and tested 3.8? |
Hi Thanks for the input,
I did close the Guake instance. Removed the old application. (Did not
reboot the host though). Installed new app version. Started it manually the
first time and inside the guake window run the --version command.
Is that correct procedure or something could be still hanging? Please let
me know.
…On Tue, Mar 15, 2022 at 10:10 AM David Yang ***@***.***> wrote:
3.8.x should have the patch. Did you confirm that you stopped the running
instance of 3.7 and tested 3.8? guake --version actually reports a
different version number to the one that is currently active if you updated
and haven't killed the previously running one. If 3.8 does still encounter
the issue then 1775 didn't fix the issue, does applying 1774 resolve it for
you? It was presumably closed by the submitter because 1775 was better but
if 1774 fixes the issue and the one merged doesn't then we can look at
getting it merged in.
—
Reply to this email directly, view it on GitHub
<#1720 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJL6FZ4RNDVH36ID5HXCQF3VACY5VANCNFSM4KUQVMOQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Exiting Guake should be enough. Can test 1774 once I have a second monitor to test since 1775 apparently didn't do it, but the submitter probably retracted it for a reason and we may need to look into this more. |
Would I be able to get a nightly build or something from the branch you mentioned so I can install and test it myself ? or maybe I would need to compile it on my machine I guess, right ? |
@OscarHanzely I see you gave a thumbs down on my other comment mentioning this, but as seen in #1720 (comment) you can just apply the change yourself. No compiling needed. |
1774 was the one that was closed, 1775 is already merged into a released version of Guake. If you have tested 1774 as per the instructions on the comment you put a thumbs down on, then neither resolve the issue for you and we need to find something else to solve this. |
I am happy to help, as many may have the same issue. Is there any debug information I can turn on and provide some logs? |
Starting Guake with |
Sorry for the delay guys, so I was observing today from the verbose what is happening. Here are logs and particular events: When Guake is launched or gained focus by clicking on the terminal window following event is triggered:
I started by opening the terminal visibility with F12 on my RIGHT monitor. Which coordinates for x would be 1920. Both monitors are same resolution. Every time the window loses the focus by clicking anywhere outside of it, regardless if its the same monitor, or second unrelated monitor, the event is triggered but with different coordinates:
Secodn monitor, my left (coordinates 0,0)
So it makes total sense, the current monitor geometry changes X value from 1920 to 0 and therefore the Now the big question is, why is this resizing window event even triggered when window looses the focus ? :) Interestinghly though, even though it shows in third log output, that window is resized to |
I just want to report, that I recently upgraded to Ubuntu 22.04 LTS and after the upgrade, the Guake stays on the spot. No more moving to another monitor with a click. Not sure what changed, as there is tons of settings reset to default, including new kernel, but it solved the problem. |
3 years and no fix ;( |
Hello,
since the last update the guake terminal is moving to the monitor I click into when it's opened.
To recreate the issue you need to have Guake opened on one window and right after clicking into the Guake terminal or opening it, click on any window or the free desktop surface on the other monitor. It only seems to work one time after Guake got the focus.
I installed Guake from this repository: ppa:linuxuprising/guake. I hope this helps recreating and fixing the issue.
Best,
Jeroen
$ guake --support
Guake Version: 3.7.0
Vte Version: 0.52.2
Vte Runtime Version: 0.52.2
GTK+ Version: 3.22.30
GDK Backend: GdkX11.X11Display
Desktop Session: ubuntu
Display: :1
RGBA visual: True
Composited: True
The text was updated successfully, but these errors were encountered: