Fix Guake application icon not displayed with German locale #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running your desktop environment with a German locale, the application icon was not found due to this typo. Tested successfully on fully upgraded Arch Linux with GNOME 3.28.1 by manually editing and fixing `/usr/share/applications/guake.desktop` and `/usr/share/applications/guake-prefs.desktop`. After the change, the correct Guake icon is showed in GNOME's application launcher instead of a "not found" placeholder icon.
rzimmer
added a commit
to rzimmer/guake
that referenced
this pull request
Jul 7, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR Guake#1320 only fixed the .desktop-file for autostart).
rzimmer
added a commit
to rzimmer/guake
that referenced
this pull request
Jul 7, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR Guake#1320 only fixed the .desktop-file for autostart).
rzimmer
added a commit
to rzimmer/guake
that referenced
this pull request
Jul 7, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR Guake#1320 only fixed the .desktop-file for autostart).
rzimmer
added a commit
to rzimmer/guake
that referenced
this pull request
Jul 8, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR Guake#1320 only fixed the .desktop-file for autostart).
rzimmer
added a commit
to rzimmer/guake
that referenced
this pull request
Jul 8, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR Guake#1320 only fixed the .desktop-file for autostart).
rzimmer
added a commit
to rzimmer/guake
that referenced
this pull request
Jul 9, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR Guake#1320 only fixed the .desktop-file for autostart).
gsemet
pushed a commit
that referenced
this pull request
Jul 9, 2018
As there is no locale-specific application icon, there is no need for having translation values for them. This commit removes all unnecessary application icon translations resulting in clearer *.desktop files. Besides, this finally fixes the Guake application icon not displayed with German locale as "de.po" put a wrong icon name into the generated *.desktop files (the merged PR #1320 only fixed the .desktop-file for autostart).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running your desktop environment with a German locale, the application icon was not found due to this typo.
Tested successfully on fully upgraded Arch Linux with GNOME 3.28.1 by manually editing and fixing
/usr/share/applications/guake.desktopand/usr/share/applications/guake-prefs.desktop.After the change, the correct Guake icon is showed in GNOME's application launcher instead of a "not found" placeholder icon.