Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background image to guake #1604

Merged
merged 12 commits into from
Sep 13, 2021
Merged

Add background image to guake #1604

merged 12 commits into from
Sep 13, 2021

Conversation

mlouielu
Copy link
Collaborator

@mlouielu mlouielu commented May 16, 2019

Impl #1603.

Impl detail please refer to guake/utils.py:BackgroundImageManager.draw

Copy link
Member

@gsemet gsemet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, but I do not see fallback mechanism for user with old version of VTE (or it should work with any version, isn’t it?) or notification that this part of the gschema and preference might not work on the user’s system

@mlouielu
Copy link
Collaborator Author

It should be used in any modern VTE version (it doesn't invoke any VTE methods), and anyone should able to use it without problem.

@gsemet
Copy link
Member

gsemet commented May 16, 2019

Oh ok you don’t use any vte function. I guess this may take some cpu to run, can check if when disabled it really does not have any impact on perf

@mlouielu mlouielu force-pushed the background-image branch from 3040337 to f3e4d62 Compare May 16, 2019 11:54
@mlouielu
Copy link
Collaborator Author

It now should cached when loading the same file (e.g. when restoring tabs).

@mlouielu mlouielu force-pushed the background-image branch from f3e4d62 to a7799e8 Compare May 17, 2019 03:36
@@ -166,6 +166,16 @@
<summary>Window vertical alignment.</summary>
<description>Place Guake at: 0: top, 1: bottom</description>
</key>
<key name="background-image-file" type="s">
<default>''</default>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indents are all off here

zeusintuivo added a commit to zeusintuivo/guake that referenced this pull request Jul 11, 2020
Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out and was sort of hoping for image transparency, but this is still nice and pretty without that. Would be nice if we used a file picker that showed thumbnails too. Both of those can get added in another commit though.

guake/data/org.guake.gschema.xml Outdated Show resolved Hide resolved
guake/utils.py Show resolved Hide resolved
@Davidy22
Copy link
Collaborator

Davidy22 commented Sep 8, 2021

In addition to polishing off that whitespace objection from @la5942, also going to need to grab the recent CI changes and make sure this passes the build and then we can merge.

@Davidy22
Copy link
Collaborator

Davidy22 commented Sep 9, 2021

Went and committed the little whitespace edit myself, just some merges and then a passthrough of black left and this should be good to go.

Copy link
Collaborator

@Davidy22 Davidy22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went and did the rebase myself. Still works, passes checks, was already approved before so merging.

@Davidy22 Davidy22 merged commit ac45448 into master Sep 13, 2021
@Davidy22 Davidy22 deleted the background-image branch May 12, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants