Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving window to correct coordinates before maximizing #1765

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Moving window to correct coordinates before maximizing #1765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19da824
moving window to correct coordinates before maximizing
May 28, 2020
98e29e2
Add release notes file
Davidy22 Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions guake/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ def set_final_window_rect(cls, settings, window):

if width_percents == 100 and height_percents == 100:
log.debug("MAXIMIZING MAIN WINDOW")
window.move(window_rect.x, window_rect.y)
window.maximize()
elif not FullscreenManager(settings, window).is_fullscreen():
log.debug("RESIZING MAIN WINDOW TO THE FOLLOWING VALUES:")
Expand Down
15 changes: 15 additions & 0 deletions ...otes/notes/fix_move_window_to_correct_coordinates_before_maximising-b5f124f36ff8d796.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
release_summary: >
Move window to correct coordinates before maximizing

features:
- |
Move the window to the correct coordinates, in the correct display, before
attempting to maximize the window.

fixes:
- |
- Guake always appears on mouse display regardless of Guake Preferences #1689
- guake follows mouse focus when have 2 monitors #1761
- Multiple monitors issue with Fedora 31 #1745
- Guake window follows mouse across monitors till it loses focus #1735
- And possibly more