Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Fix prompt on close tab #1885

Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix:Fix prompt on close tab #1885

merged 1 commit into from
Sep 10, 2021

Conversation

Davidy22
Copy link
Collaborator

@Davidy22 Davidy22 commented Sep 9, 2021

PromptQuitDialog creation was passed wrong number of arguments, last argument is unused in this situation so passed None into it.

Fixes #1863 and possibly #1812

PromptQuitDialog creation had wrong number of arguments, last argument is unused in this situation so passed None into it.
@Davidy22 Davidy22 requested a review from mlouielu September 9, 2021 23:42
@Davidy22 Davidy22 changed the title Fix prompt on close tab fix:Fix prompt on close tab Sep 9, 2021
@Davidy22 Davidy22 mentioned this pull request Sep 9, 2021
@gsemet gsemet merged commit 0eecd43 into Guake:master Sep 10, 2021
@gsemet
Copy link
Member

gsemet commented Sep 10, 2021

Merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot close tab
2 participants