Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore COMPILE_SCHEMA option #1895

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Restore COMPILE_SCHEMA option #1895

merged 1 commit into from
Sep 13, 2021

Conversation

Davidy22
Copy link
Collaborator

Restoring as per review #1893 (review)

made a little whoops

@eli-schwartz
Copy link
Collaborator

As mentioned in the linked comment, we can look at this as a fortuitous opportunity to change how this works and just check whether DESTDIR is empty. If it is empty, then post install routines such as triggering a glib schemas rebuild of the compiled schemas cache, need to be re-run. If it is not empty, then the path which the files have just been copied to is not the "real" installation and creating the schemas cache will just conflict with the live system once once the two filesystem trees are merged (e.g. by installing the distro package), hence it should not be created.

This will also serve as documentation for the future, that skipping a recompile is relevant specifically to distros and other people who use DESTDIR.

@gsemet gsemet merged commit 09a958a into Guake:master Sep 13, 2021
@gsemet
Copy link
Member

gsemet commented Sep 13, 2021

I let you deal with it. it is a tricky part I do not remember how to make it work on all use cases:

  • dev environemt with the virtualenv
  • make install (probably never really used)
  • rpm/deb packaged (the package maintainer may use the result of what make install does)
  • pip install guake in users' local env
  • and maybe one day pipx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants